New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: Add type hints to utils.py and FilterEngine, refactoring code where needed #6604
Open
rdimaio
wants to merge
4
commits into
rucio:master
Choose a base branch
from
rdimaio:feature-6588-utils
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bari12
previously approved these changes
Apr 26, 2024
Please rebase |
rdimaio
force-pushed
the
feature-6588-utils
branch
from
April 26, 2024 15:10
3fee6f7
to
3fcd17e
Compare
Rebased in latest force-push |
rdimaio
force-pushed
the
feature-6588-utils
branch
from
April 29, 2024 10:48
3fcd17e
to
6ad3097
Compare
Latest force-push:
|
rdimaio
force-pushed
the
feature-6588-utils
branch
from
April 29, 2024 11:03
6ad3097
to
ac49f5f
Compare
Latest forcepush: fixed two issues that arose from the rebase that I had missed |
bari12
previously approved these changes
May 21, 2024
Rebase please :-) |
rdimaio
force-pushed
the
feature-6588-utils
branch
from
May 21, 2024 13:00
ac49f5f
to
2a1e9aa
Compare
Rebased in latest force-push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6588.
b3227b1
BaseClient
constructor is refactored in a way where the static type checker can detect thathost
andauth_host
are neverNone
.d5d3d67
utils.py
. The methods here are used in a few places, and there are some instances where the input types are unclear, so I addedtype: ignore
comments in places where the issue seems to be with the parent function rather than the util function. Some notes below.oidc.py
filter_engine.py
4d2808d
re.match(str(cfg_forced_modules), module_name)
ifmodule_name
isNone
.3fee6f7
parse_did_filter_from_string_fe
inutils.py
, which is then called inFilterEngine
. I added type hints all around to make it easier to understand which types were being passed inFilterEngine
, as well as refactoring some stuff where needed for type hinting purposes.